Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opusfile: fix building for Android with http=True #26245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kambala-decapitator
Copy link
Contributor

@kambala-decapitator kambala-decapitator commented Dec 22, 2024

Summary

Changes to recipe: opusfile/all

Motivation

Fixes building opusfile with http=True for Android

Details

There're 2 issues:

  1. Build fails due to using C99 features but compiling in C89 mode. I've opened issue in upstream Android build error with Autotools xiph/opusfile#52 as I'm not sure what's the right way to proceed here (if I can blindly replace 89 with 99). In the recipe I replace 89 with 99 only for Android (because again I'm not sure if there will be any side effects on other platforms), but doing it in generate as access to self.settings is forbidden in source.
  2. Build for 32-bit fails due to using unavailable symbols, the fix is the same as FLAC: Fix building for 32-bit Android against API level < 24 #26240. I have also raised PR in upstream: fix building for 32-bit Android with API level < 24 xiph/opusfile#53

Also moved patching sources from build to source which is the recommended way nowadays.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant